Pass down the EngineConfig to IndexSearcherWrapper #12883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param searcher The provided index searcher to be wrapped to add custom functionality | ||
| * @param searcher The provided index searcher to be wrapped to add custom functionality | ||
| * @param engineConfig The engine config which can be created to get the query cache and query cache policy from | ||
| * when creating a new index searcher |
There was a problem hiding this comment.
Shouldn't the @param engineConfig come first in the javadocs, since it's first in the args?
There was a problem hiding this comment.
yes, it should, I'll change it.
|
LGTM, I just left a minor comment about the javadocs... |
If a new IndexSearcher gets created the engine config can be used to get the query cache and query cache policy from.
martijnvg
force-pushed
the
index_seacher_wrapper_pass_down_engine_config
branch
from
0800815
to
2b97f5d
Compare
|
@martijnvg This is labeled as 2.0 but I can only see it in the master branch? Should it be backported or should we fix the version labels on this PR? |
|
@jpountz I think we should back port it. I'll do it once the beta release is out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a new IndexSearcher gets created in an
IndexSearcherWrapperimplementation then the engine config can be used to get the query cache and query cache policy from. Otherwise the newIndexSearcherbeing created uses the incorrect query cache and query cache policy.