Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure localhost works on IPv4 and IPv6 #12906

Closed
clintongormley opened this issue Aug 15, 2015 · 2 comments
Closed

Ensure localhost works on IPv4 and IPv6 #12906

clintongormley opened this issue Aug 15, 2015 · 2 comments
Assignees
@rmuir
Labels
>bug :Distributed/Network Http and internode communication implementations help wanted adoptme

Comments

@clintongormley
Copy link

Today we use localhost in all of our curl examples, but Elasticsearch is binding to either 127.0.0.1 or ::1, and localhost may not work.

We should try to bind to both.
@clintongormley clintongormley added >bug help wanted adoptme :Distributed/Network Http and internode communication implementations v2.0.0-beta2 v2.0.0 and removed v2.0.0-beta2 labels Aug 15, 2015
@dakrone
Copy link
Member

dakrone commented Aug 16, 2015

Related to #12914 and #12915

@rmuir rmuir self-assigned this Aug 17, 2015
@rmuir
Copy link
Contributor

rmuir commented Aug 17, 2015

I'm working on this: I've made progress but need a few more hours to have something to show.

@rmuir rmuir mentioned this issue Aug 17, 2015
Closed
@rmuir rmuir closed this as completed in 68307aa Aug 17, 2015
rmuir added a commit that referenced this issue Aug 18, 2015
@rmuir
Fix network binding for ipv4/ipv6
b3a9abb 
When elasticsearch is configured by interface (or default: loopback interfaces),
bind to all addresses on the interface rather than an arbitrary one.

If the publish address is not specified, default it from the bound addresses
based on the following sort ordering:

* ipv4/ipv6 (java.net.preferIPv4Stack, defaults to true)
* ordinary addresses
* site-local addresses
* link local addresses
* loopback addresses

One one address is published, and multicast is still always over ipv4: these
need to be future improvements.

Closes #12906
Closes #12915

Squashed commit of the following:

commit 7e60833
Author: Robert Muir <rmuir@apache.org>
Date:   Mon Aug 17 14:45:33 2015 -0400

    fix java 7 compilation oops

commit c7b9f3a
Author: Robert Muir <rmuir@apache.org>
Date:   Mon Aug 17 14:24:16 2015 -0400

    Cleanup/fix logic around custom resolvers

commit bd7065f
Author: Robert Muir <rmuir@apache.org>
Date:   Mon Aug 17 13:29:42 2015 -0400

    Add some unit tests for utility methods

commit 0faf71c
Author: Robert Muir <rmuir@apache.org>
Date:   Mon Aug 17 12:11:48 2015 -0400

    localhost all the way down

commit e198bb2
Merge: b55d092 b93a75f
Author: Robert Muir <rmuir@apache.org>
Date:   Mon Aug 17 12:05:02 2015 -0400

    Merge branch 'master' into network_cleanup

commit b55d092
Author: Robert Muir <rmuir@apache.org>
Date:   Mon Aug 17 12:03:03 2015 -0400

    fix docs, fix another bug in multicast (publish host = bad here!)

commit 88c462e
Author: Robert Muir <rmuir@apache.org>
Date:   Mon Aug 17 11:50:49 2015 -0400

    remove nocommit

commit 89547d7
Author: Robert Muir <rmuir@apache.org>
Date:   Mon Aug 17 11:49:35 2015 -0400

    fix http too

commit 9b9413a
Author: Robert Muir <rmuir@apache.org>
Date:   Mon Aug 17 11:06:02 2015 -0400

    Fix transport / interface code

    Next up: multicast and then http
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmuir rmuir

Labels
>bug :Distributed/Network Http and internode communication implementations help wanted adoptme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix network binding for ipv4/ipv6 rmuir/elasticsearch
3 participants
@dakrone @clintongormley @rmuir