Cleanup bootstrap package. #13053
Merged
Cleanup bootstrap package. #13053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* makes most classes final and package private * removes duplicate and confusing multiple entry points * adds javadocs to some classes like JarHell,Security * adds a public class BootStrapInfo that exposes any stats needed by outside code.
|
Looks good to me |
|
Privatizing these kinds of things may make it harder for users to extend/customize the ES code, or to support other creative use cases like ES embedded inside another app/container. |
|
This code is not extendable. Its not intended for extension. |
|
@vinhn if you want to embed an ES node, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup the bootstrap package a bit:
needed by outside code.
Closes #13044