Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows service doesn't stop properly #13401

Closed
gmarz opened this issue Sep 8, 2015 · 2 comments
Closed

Windows service doesn't stop properly #13401

gmarz opened this issue Sep 8, 2015 · 2 comments
Labels
>bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team v2.0.0-beta2

Comments

@gmarz
Copy link
Contributor

gmarz commented Sep 8, 2015

After addressing the issues in #13247 and getting the service to start. Stopping the service in 2.x/master no longer works either and fails with the following error:

2015-09-08 09:38:56 Commons Daemon procrun stderr initialized
java.lang.NoSuchMethodError: close

Apache Commons Daemon procrun requires a stop method (--StopMethod), which use to exist but has been removed.

Can this be added back?

@gmarz gmarz added >bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v2.0.0 labels Sep 8, 2015
@rmuir
Copy link
Contributor

rmuir commented Sep 8, 2015

I think its fine, as long as we add comments about how its used? There were tons of methods like this in bootstrap: I probably removed a bunch of them. Technically, this one just needs to call Bootstrap.INSTANCE.stop() I think.

@gmarz
Copy link
Contributor Author

gmarz commented Sep 8, 2015

Thanks @rmuir, I've updated #13398 to include this as well.

gmarz added a commit to gmarz/elasticsearch that referenced this issue Sep 9, 2015
This commit addresses several bugs that prevented the Windows
service from being started or stopped:

- Extra white space in the concatenation of java options in
  elasticsearch.in.bat which tripped up Apache Commons Daemon
  and caused ES to startup without any params, eventually leading
  to the "path.home is not configured" exception.

- service.bat was not passing the start argument to ES

- The service could not be stopped gracefully via the stop command
  because there wasn't a method for procrun to call.

Closes elastic#13247
Closes elastic#13401
gmarz added a commit that referenced this issue Sep 9, 2015
This commit addresses several bugs that prevented the Windows
service from being started or stopped:

- Extra white space in the concatenation of java options in
  elasticsearch.in.bat which tripped up Apache Commons Daemon
  and caused ES to startup without any params, eventually leading
  to the "path.home is not configured" exception.

- service.bat was not passing the start argument to ES

- The service could not be stopped gracefully via the stop command
  because there wasn't a method for procrun to call.

Closes #13247
Closes #13401
@gmarz gmarz closed this as completed in 9e6115b Sep 9, 2015
gmarz added a commit that referenced this issue Sep 9, 2015
This commit addresses several bugs that prevented the Windows
service from being started or stopped:

- Extra white space in the concatenation of java options in
  elasticsearch.in.bat which tripped up Apache Commons Daemon
  and caused ES to startup without any params, eventually leading
  to the "path.home is not configured" exception.

- service.bat was not passing the start argument to ES

- The service could not be stopped gracefully via the stop command
  because there wasn't a method for procrun to call.

Closes #13247
Closes #13401
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team v2.0.0-beta2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants