Added support for highlighting multi term queries using the postings highlighter #4052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| private static final IndexReader EMPTY_INDEXREADER = new MultiReader(); | ||
| private static Query rewrite(Query original, IndexReader reader) throws IOException { | ||
| if (original instanceof MultiTermQuery) { | ||
| MultiTermQuery copy = (MultiTermQuery) original.clone(); |
There was a problem hiding this comment.
I don't think you need to clone the query you can just get the current rewrite method and set it back once you are done? If the rewrite method already allows term extraction we don't need to do anything and if so you can also set the query back into the context via updateRewriteQuery?
|
+1 lgtm! |
|
+1 looks great! |
|
Merged |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Feb 21, 2014
…level queries In elastic#4052 we added support for highlighting multi term queries using the postings highlighter. That worked only for top-level queries though, and not for multi term queries that are nested for instance within a bool query, or filtered query, or a constant score query. The way we make this work is by walking the query structure and temporarily overriding the query rewrite method with a method that allows for multi terms extraction. Closes elastic#5102
javanna
added a commit
that referenced
this pull request
Feb 21, 2014
…level queries In #4052 we added support for highlighting multi term queries using the postings highlighter. That worked only for top-level queries though, and not for multi term queries that are nested for instance within a bool query, or filtered query, or a constant score query. The way we make this work is by walking the query structure and temporarily overriding the query rewrite method with a method that allows for multi terms extraction. Closes #5127
javanna
added a commit
that referenced
this pull request
Feb 21, 2014
…level queries In #4052 we added support for highlighting multi term queries using the postings highlighter. That worked only for top-level queries though, and not for multi term queries that are nested for instance within a bool query, or filtered query, or a constant score query. The way we make this work is by walking the query structure and temporarily overriding the query rewrite method with a method that allows for multi terms extraction. Closes #5127
javanna
added a commit
that referenced
this pull request
Feb 21, 2014
…level queries In #4052 we added support for highlighting multi term queries using the postings highlighter. That worked only for top-level queries though, and not for multi term queries that are nested for instance within a bool query, or filtered query, or a constant score query. The way we make this work is by walking the query structure and temporarily overriding the query rewrite method with a method that allows for multi terms extraction. Closes #5127
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…level queries In elastic#4052 we added support for highlighting multi term queries using the postings highlighter. That worked only for top-level queries though, and not for multi term queries that are nested for instance within a bool query, or filtered query, or a constant score query. The way we make this work is by walking the query structure and temporarily overriding the query rewrite method with a method that allows for multi terms extraction. Closes elastic#5127
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…level queries In elastic#4052 we added support for highlighting multi term queries using the postings highlighter. That worked only for top-level queries though, and not for multi term queries that are nested for instance within a bool query, or filtered query, or a constant score query. The way we make this work is by walking the query structure and temporarily overriding the query rewrite method with a method that allows for multi terms extraction. Closes elastic#5127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rewrite of the query using the current top level reader instead of an empty one, rewritten all multi term queries using
TopTermsScoringBooleanQueryRewrite(1024)rewrite mode.As a result, postings highlighter supports now wildcard query, prefix query, fuzzy query, term range query and regexp query.
Closes #4042