Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature external version 'force' option #4213

Closed
frazerh opened this issue Nov 20, 2013 · 3 comments
Closed

Feature external version 'force' option #4213

frazerh opened this issue Nov 20, 2013 · 3 comments

Comments

@frazerh
Copy link

frazerh commented Nov 20, 2013

Many times it would have been useful to force the update of a document ignoring the version when the version type is external. This is useful when trying to keep the external version in sync with the db optimistic lock version.

@ghost ghost assigned bleskes Nov 20, 2013
@bleskes
Copy link
Contributor

bleskes commented Nov 20, 2013

Hi Frazerh,

We could build something like this but I want to understand the use case a bit more to make sure we do the proper thing. Currently the external versioning will update a document only if the incoming version is higher than the stored one. I assume that still holds if you use optimistic locking to update your db and ES is updated once the db update succeeds?

@frazerh
Copy link
Author

frazerh commented Nov 21, 2013

Hey @bleskes, yes the above still holds true. On occasion we just need to be able to override this and force and index ignoring the external version.

@bleskes
Copy link
Contributor

bleskes commented Nov 21, 2013

K. Fair enough. I'll look at the implications of allowing you to force set the version number. Thanks for clarifying.

bleskes added a commit to bleskes/elasticsearch that referenced this issue Feb 2, 2014
Also added "external_gt" as an alias name for VersionType.EXTERNAL , accessible for the rest layer.

 Closes elastic#4213 , Closes elastic#2946
bleskes added a commit that referenced this issue Mar 10, 2014
Also added "external_gt" as an alias name for VersionType.EXTERNAL , accessible for the rest layer.

Closes #4213 , Closes #2946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants