Remove redundant version checks in transport serialisation #4731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks great - we can pull this in post RC1 |
| } else { | ||
| peroclate = new PercolateStats(); | ||
| } | ||
| peroclate = PercolateStats.readPercolateStats(in); |
|
I think we should be able to remove the read/writeTimeout methods in |
|
@javanna Make sense, I'll remove these methods. |
Removed AcknowledgedRequest#readTimeout(StreamInput, Version) and AcknowledgedRequest#writeTimeout(StreamOutput, Version)
|
Updated PR to implement Luca's feedback. |
|
|
||
| } | ||
|
|
||
| @Test | ||
| public void testDeleteWarmerTimeoutBwComp_Post0906Format() throws Exception { |
There was a problem hiding this comment.
just nitpicking, maybe we could change the name of the test method that's left, or even remove it? I don't think we need to explicitly test the serialization here anymore...
|
I left a small comment, but looks great @martijnvg , thanks! |
|
@javanna Thanks for the feedback. Pushed to master, 1.x and 1.0 branches. |
javanna
added a commit
that referenced
this pull request
Jan 24, 2014
javanna
added a commit
that referenced
this pull request
Jan 24, 2014
javanna
added a commit
that referenced
this pull request
Jan 24, 2014
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.0 breaks transport serialisation support with 0.90.x, it doesn't make sense to do version checks in the serialisation code. This will clean up the code (writeTo() and readFrom()) and allows ES to start fresh.