Made possible to dynamically update discovery.zen.publish_timeout cluster setting
#5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public void onRefreshSettings(Settings settings) { | ||
| TimeValue newPublishTimeout = settings.getAsTime(PUBLISH_TIMEOUT, null); | ||
| if (newPublishTimeout != null) { | ||
| if (newPublishTimeout.millis() != publishTimeout.millis() ) { |
There was a problem hiding this comment.
there is a whitespace too much here ;)
|
LGTM |
…luster setting `discovery.zen.publish_timeout` controls how long the master node is going to try and wait for all the nodes to respond to a cluster state publish before going ahead with the following updates in the queue (default 30s). Up until now changing the settings required restarting each node. The setting is now dynamic and can be changed through the cluster update settings api. Closes elastic#5063
clintongormley
added
>enhancement
v1.1.0
v2.0.0-beta1
:Core/Infra/Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discovery.zen.publish_timeoutcontrols how long the master node is going to try and wait for all the nodes to respond to a cluster state publish before going ahead with the following updates in the queue (default 30s). Up until now changing the settings required restarting each node. The setting is now dynamic and can be changed through the cluster update settings api.Closes #5063