New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to get snapshot status for running snapshots #5123
Conversation
I will look at this asap - I guess tomorrow or tonight |
* | ||
* @return true if snapshot completed, false otherwise | ||
*/ | ||
public boolean completed() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you can pass this as a ctor argument to the enum instances?
I left some comments but in general it looks good |
@s1monw, I've updated the PR based on your comments. Thanks! |
nodesList.add((NodeSnapshotStatus) resp); | ||
} else if (resp instanceof FailedNodeException) { | ||
failures.add((FailedNodeException) resp); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can the resp be anything else and if so should we throw an exception or log it?
@imotov I left one minor comment I think this LGTM |
LGTM +1 to push |
|
||
|
||
[float] | ||
=== Snapshot status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should mark it as coming 1.1.0
, right?
See https://groups.google.com/d/msgid/elasticsearch/17B720BE-C665-498A-AAFA-030F8DC50AE1%40hartl.name?utm_medium=email&utm_source=footer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #4946