Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get snapshot status for running snapshots #5123

Merged
merged 1 commit into from Mar 18, 2014

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Feb 14, 2014

Closes #4946

@s1monw
Copy link
Contributor

s1monw commented Feb 24, 2014

I will look at this asap - I guess tomorrow or tonight

*
* @return true if snapshot completed, false otherwise
*/
public boolean completed() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can pass this as a ctor argument to the enum instances?

@s1monw
Copy link
Contributor

s1monw commented Mar 11, 2014

I left some comments but in general it looks good

@imotov
Copy link
Contributor Author

imotov commented Mar 17, 2014

@s1monw, I've updated the PR based on your comments. Thanks!

nodesList.add((NodeSnapshotStatus) resp);
} else if (resp instanceof FailedNodeException) {
failures.add((FailedNodeException) resp);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the resp be anything else and if so should we throw an exception or log it?

@s1monw
Copy link
Contributor

s1monw commented Mar 17, 2014

@imotov I left one minor comment I think this LGTM

@s1monw
Copy link
Contributor

s1monw commented Mar 17, 2014

LGTM +1 to push

@imotov imotov merged commit a119204 into elastic:master Mar 18, 2014


[float]
=== Snapshot status
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadoonet - done in 3414deb. Thanks!

@clintongormley clintongormley added the :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs label Jun 7, 2015
@imotov imotov deleted the issue-4946-snapshot-status branch May 1, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement v1.1.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stats for running snapshot to get snapshot API
4 participants