Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query_string and simple_query_string should allow selective a Locale #5128

Closed
dakrone opened this issue Feb 14, 2014 · 3 comments
Closed

query_string and simple_query_string should allow selective a Locale #5128

dakrone opened this issue Feb 14, 2014 · 3 comments
Assignees
@dakrone
Labels
>enhancement v1.1.0 v2.0.0-beta1

Comments

@dakrone
Copy link
Member

dakrone commented Feb 14, 2014

query_string currently defaults to Locale.getDefault() while simple_query_string uses Locale.ROOT.

We should add a "locale" option to both queries that allows the user to select a locale, and unify the defaults to be the same.
@dakrone dakrone mentioned this issue Feb 14, 2014
Closed
@s1monw
Copy link
Contributor

s1monw commented Feb 14, 2014

+1

@dakrone
Copy link
Member Author

dakrone commented Feb 14, 2014

@s1monw what do you think the default should be? Locale.getDefault() or Locale.ROOT?

@s1monw
Copy link
Contributor

s1monw commented Feb 14, 2014

IMO it should be ROOT so it's consistent whereever you use it and then it can be change via the request if you like to

@dakrone dakrone mentioned this issue Feb 14, 2014
Closed
@dakrone dakrone self-assigned this Feb 14, 2014
dakrone added a commit to dakrone/elasticsearch that referenced this issue Feb 20, 2014
@dakrone
Add "locale" parameter to query_string and simple_query_string
a6c54bb 
Fixes elastic#5128

Remove java 7 specific Locale functions, add "coming[1.1.0]" to documentation

add LocaleUtils utility class for dealing with Locale functions
dakrone added a commit that referenced this issue Feb 20, 2014
@dakrone
Add "locale" parameter to query_string and simple_query_string
efc00fd 
Fixes #5128

Remove java 7 specific Locale functions, add "coming[1.1.0]" to documentation

add LocaleUtils utility class for dealing with Locale functions
@colings86 colings86 mentioned this issue Aug 19, 2014
Closed
colings86 added a commit that referenced this issue Sep 12, 2014
@colings86
Geo: Fixes BoundingBox across complete longitudinal range
f8d75fa 
Adds a special case to the GeoBoundingBoxFilterParser so that the left of the box is not normalised in the case where left and right are 360 apart.  Before this change the left would be normalised to 180 in this case and the filter would only match points with a longitude of 180 (or -180).

Closes #5128
colings86 added a commit that referenced this issue Sep 12, 2014
@colings86
Geo: Fixes BoundingBox across complete longitudinal range
e6816e1 
Adds a special case to the GeoBoundingBoxFilterParser so that the left of the box is not normalised in the case where left and right are 360 apart.  Before this change the left would be normalised to 180 in this case and the filter would only match points with a longitude of 180 (or -180).

Closes #5128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakrone dakrone

Labels
>enhancement v1.1.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "locale" parameter to query_string and simple_query_string dakrone/elasticsearch
2 participants
@dakrone @s1monw