"include_in_all": false not working for nested multi-field mappings

[asanderson]

I'm running Elasticsearch 1.0.1 using the following $ES_HOME/config/default-mapping.json:

{
  "_default_": {
    "properties": {
      "foo": {
        "type": "nested",
        "include_in_all": false,
        "properties": {
          "bar": {
            "type": "string",
            "index": "not_analyzed",
            "include_in_all": false,
            "fields": {
              "lower": {
                "analyzer": "standard",
                "type": "string"
              }
            }
          }
        }
      }
    }
  }
}

When I post the following, the include_in_all does not seem to be recognized at any level:

 {
   "foo": {
     "bar": "Elasticsearch rules!"
   }
 }

The resulting metadata is the following:

{
    state: open
    settings: {
        index: {
            uuid: S2hmo2d3SGWFP51PXs6XbA
            number_of_replicas: 0
            number_of_shards: 1
            version: {
                created: 1000199
            }
        }
    }
    mappings: {
        foobar: {
            properties: {
               foo: {
                   include_in_all: false
                    properties: {
                        bar: {
                            include_in_all: false
                            index: not_analyzed
                            type: string
                            fields: {
                                lower: {
                                    analyzer: standard
                                    type: string
                                }
                            }
                        }
                    }
                    type: nested
                }
            }
        }
    }
    aliases: [ ]
}

I verified that _all does include the "elasticsearch rules" via the following aggregation search:

{
  "aggs": {
    "foobar": {
      "terms": {
        "field": "_all"
      }
    }
  },
  "size": 0
}

The aggs search result is the following:

{
    took: 36
    timed_out: false
    _shards: {
        total: 1
        successful: 1
        failed: 0
    }
    hits: {
        total: 1
        max_score: 0
        hits: [ ]
    }
    aggregations: {
        foo: {
            buckets: [
                {
                    key: elasticsearch
                    doc_count: 1
                }
                {
                    key: rule
                    doc_count: 1
                }
            ]
        }
    }
}

So, _all should be empty, but it is not.

[clintongormley]

Confirmed that this is a problem. I also tried setting include_in_root and include_in_parent to false, but the values still end up in _all.

[martijnvg]

This has been fixed via PR #5522