Use BytesReference to write to translog files #5463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using byte arrays, pass the BytesReference to the actual translog file, and use the new copyTo(channel) method to write. This will improve by not potentially having to convert the data to a byte array
| @@ -96,6 +97,11 @@ public static int bytesHashCode(BytesReference a) { | |||
| void writeTo(OutputStream os) throws IOException; | |||
|
|
|||
| /** | |||
| * Writes the bytes directly to the channel. | |||
| */ | |||
| void writeTo(GatheringByteChannel channel) throws IOException; | |||
There was a problem hiding this comment.
Should it be just WritableByteChannel instead of GatheringByteChannel?
There was a problem hiding this comment.
netty channel buffer uses GatheringByteChannel for its getBytes version, and its nice to have the option to write ByteBuffer[]. All relevant actual implementations end up implementing GatheringByteChannel so I thought it just makes sense.
|
+1 |
kimchy
added a commit
that referenced
this pull request
Mar 19, 2014
Instead of using byte arrays, pass the BytesReference to the actual translog file, and use the new copyTo(channel) method to write. This will improve by not potentially having to convert the data to a byte array closes #5463
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using byte arrays, pass the BytesReference to the actual translog file, and use the new copyTo(channel) method to write. This will improve by not potentially having to convert the data to a byte array