Aggregation cleanup #5699
Closed
Aggregation cleanup #5699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
uboness
commented
Apr 6, 2014
uboness
commented
- consolidated value source parsing under a single parser that is reused in all the value source aggs parsers
- consolidated include/exclude parsing under a single parser
- cleaned up value format handling, to have consistent behaviour across all values source aggs
| extendedBounds.processAndValidate(name, aggregationContext.searchContext(), parser); | ||
| roundedBounds = extendedBounds.round(rounding); | ||
| } | ||
| return new HistogramAggregator(name, factories, rounding, order, keyed, minDocCount, roundedBounds, valuesSource, formatter, parser, 50, histogramFactory, aggregationContext, parent); | ||
| ValueFormatter formatter = config.format() != null ? config.format().formatter() : null; | ||
| return new HistogramAggregator(name, factories, rounding, order, keyed, minDocCount, roundedBounds, valuesSource, formatter, 50, histogramFactory, aggregationContext, parent); |
There was a problem hiding this comment.
Could we have helper methods on the config object to get the parser and formatter?
|
Very nice, I really like how you share the parsing of the values sources! |
- consolidated value source parsing under a single parser that is reused in all the value source aggs parsers - consolidated include/exclude parsing under a single parser - cleaned up value format handling, to have consistent behaviour across all values source aggs
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.