Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include name of field that caused circuit breaking exception #5718

Closed
dakrone opened this issue Apr 7, 2014 · 3 comments · Fixed by #5841
Closed

Include name of field that caused circuit breaking exception #5718

dakrone opened this issue Apr 7, 2014 · 3 comments · Fixed by #5841

Comments

@dakrone
Copy link
Member

dakrone commented Apr 7, 2014

We could include the name of the field that is potentially blowing out memory with the exception so it's easier for people to tell which field is using the memory.

This could still be a bit misleading when loading more than one field at a time, but may be more useful than not including any field name.

@dakrone dakrone self-assigned this Apr 7, 2014
@kimchy
Copy link
Member

kimchy commented Apr 7, 2014

++, it would be nice to improve the failure from data would be larger than limit of [large_number_here] to data would be larger than limit of [large_number_here/human number here], so its simpler to know right away what the limit here.

@dakrone
Copy link
Member Author

dakrone commented Apr 7, 2014

Yes, I agree, I'll add that as well.

@s1monw
Copy link
Contributor

s1monw commented Apr 14, 2014

++ - would be good to get this into 1.2.0

dakrone added a commit to dakrone/elasticsearch that referenced this issue Apr 23, 2014
dakrone added a commit that referenced this issue Apr 23, 2014
mikemccand pushed a commit to mikemccand/elasticsearch that referenced this issue Apr 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants