Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trimmed the main elasticsearch.yml configuration file #5861

Merged
merged 1 commit into from May 4, 2015
Merged

Conversation

karmi
Copy link
Contributor

@karmi karmi commented Apr 17, 2014

This patch significantly trims the main elasticsearch.yml configuration file.

The current elasticsearch.yml file is a relic of the past, when Elasticsearch
documentation has been more dispersed and incomplete.

It has improved significantly, so the main configuration can be slimmed down,
and contain only the most important settings for development and production use.

Related: 8d0f1a7

@dakrone
Copy link
Member

dakrone commented Apr 17, 2014

I still think I favor moving the "discovery" section to right underneath the cluster setting, as minimum_master_nodes is one of the most important settings that needs to be set.

@seang-es
Copy link

I agree with @dakrone that Discovery, Gateway and Cluster should be next to each other, as they all relate to cluster topology and would tend to be modified together.

@karmi
Copy link
Contributor Author

karmi commented Apr 19, 2014

Arguably, setting the node name is even more important (since it doesn't stick after restart otherwise), and also the data/log path (since it's quite probably in a different place then it should be otherwise).

The new file is 100 lines of code, and the assumption is that all settings will be reviewed for a serious deployment. With that in mind, the "Network" section can be moved before "Various" just fine.

@dakrone dakrone added the discuss label Jul 4, 2014
@s1monw
Copy link
Contributor

s1monw commented Aug 22, 2014

@karmi we discussed this today and we want to move on with what we have. I think we should push what we have (progress over perfection). Given the changes to the config related to scripting and jsonp I guess you should go over it again, can you talk a look at it again?

@s1monw s1monw self-assigned this Aug 22, 2014
@karmi
Copy link
Contributor Author

karmi commented Aug 22, 2014

(...) we want to move on with what we have.

Where by "what we have" we mean this trimmed configuration, or the current master one?

I'll assign the issue to myself, and will review the content against the new changes you mention next week!

@karmi
Copy link
Contributor Author

karmi commented Aug 29, 2014

Force-pushed a commit rebased against current master.

I was thinking a bit about JSONP, dynamic scripting, etc., but I don't see them as something to add into the concise configuration this pull request proposes.

@dakrone
Copy link
Member

dakrone commented Sep 2, 2014

I think we should leave out the config for dynamic scripting since we have sandboxing now, enabling it should be a very advanced setting and not something people reach for at the beginning.

@clintongormley clintongormley changed the title Trimmed the main elasticsearch.yml configuration file Settings: Trimmed the main elasticsearch.yml configuration file Sep 9, 2014
@s1monw
Copy link
Contributor

s1monw commented Sep 10, 2014

I am pushing this out to 1.5

@clintongormley
Copy link

@karmi any chance you can give this a final check and get it merged? thanks

@karmi
Copy link
Contributor Author

karmi commented May 1, 2015

@clintongormley @s1monw So, what can I do to have this merged? I went over the current elasticsearch.yml and I don't see anything to add to this pruned version.

@lukas-vlcek
Copy link
Contributor

@karmi How about updating links elasticsearch.org -> elastic.co ?

@karmi
Copy link
Contributor Author

karmi commented May 1, 2015

@lukas-vlcek Fair point, will do, thanks!

The main `elasticsearch.yml` file mixed configuration, documentation
and advice together.

Due to a much improved documentation at <http://www.elastic.co/guide/>,
the content has been trimmed, and only the essential settings have
been left, to prevent the urge to excessive over-configuration.

Related: 8d0f1a7
@karmi
Copy link
Contributor Author

karmi commented May 2, 2015

Rebased against master and update the URLs to point to http://elastic.co.

@s1monw
Copy link
Contributor

s1monw commented May 4, 2015

this looks good to me - I will pull this in now and turn the discussion into discuss if you wanna add not if you wanna remove. I think our config is a settings cheatsheet which we can have separately.

s1monw added a commit that referenced this pull request May 4, 2015
Settings: Trimmed the main `elasticsearch.yml` configuration file
@s1monw s1monw merged commit 9e82d3e into master May 4, 2015
@s1monw s1monw deleted the trim-config branch May 4, 2015 07:42
@karmi
Copy link
Contributor Author

karmi commented May 4, 2015

@s1monw Thanks!!

@clintongormley clintongormley changed the title Settings: Trimmed the main elasticsearch.yml configuration file Trimmed the main elasticsearch.yml configuration file Jun 7, 2015
karmi added a commit to sous-chefs/elasticsearch that referenced this pull request Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants