More Like This API would not take into account size and from in request body #5981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix looks good. Can we also have a test for it? |
| .field("text", "lucene").endObject())) | ||
| .actionGet(); | ||
| } | ||
| refresh(); |
There was a problem hiding this comment.
Can you use indexRandom? This method randomizes document order to make sure that the test doesn't rely on it.
|
LGTM |
More Like This API would not take into account 'size' and 'from' in request body parameters. Instead these values would always be overriden by the default values of REST parameters 'search_size' and 'search_from'. Closes elastic#5981
alexksikes
added a commit
that referenced
this pull request
May 12, 2014
More Like This API would not take into account 'size' and 'from' in request body parameters. Instead these values would always be overriden by the default values of REST parameters 'search_size' and 'search_from'. Closes #5981
clintongormley
changed the title
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead these values would always be overridden by the default values of REST parameters search_size and search_from.