Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log script change/add and removal at INFO level #6104

Merged
merged 1 commit into from May 13, 2014

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented May 9, 2014

Now that dynamic scripting is disabled, it's extremely helpful to know if/when a script is added or removed via the ScriptChangesListener, previously these were only TRACE level messages, they now look like:

[2014-05-09 12:01:25,393][INFO ][script                   ] [Plunderer] compiling script file [/Users/hinmanm/src/elasticsearch/config/scripts/calculate-score.mvel]
[2014-05-09 12:02:25,397][INFO ][script                   ] [Plunderer] compiling script file [/Users/hinmanm/src/elasticsearch/config/scripts/test.mvel]
[2014-05-09 12:03:25,399][INFO ][script                   ] [Plunderer] removing script file [/Users/hinmanm/src/elasticsearch/config/scripts/test.mvel]

To give an indication as to when the script changes have noticed and the scripts added/reloaded/removed.

@pickypg
Copy link
Member

pickypg commented May 9, 2014

LGTM. Certainly an improvement to have it pass in the argument as opposed to always concatenating it anyway.

@jpountz
Copy link
Contributor

jpountz commented May 12, 2014

It looks good to me as well!

dakrone added a commit that referenced this pull request May 13, 2014
@dakrone dakrone merged commit 3484ca3 into elastic:master May 13, 2014
@dakrone dakrone removed the review label May 13, 2014
@dakrone dakrone deleted the log-scripting-reloads branch September 9, 2014 13:53
@clintongormley clintongormley added >enhancement :Core/Infra/Logging Log management and logging utilities labels Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants