Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Removing plugin does not fail when plugin dir is read only #6546

Closed
dadoonet opened this issue Jun 18, 2014 · 2 comments
Closed

Plugins: Removing plugin does not fail when plugin dir is read only #6546

dadoonet opened this issue Jun 18, 2014 · 2 comments

Comments

@dadoonet
Copy link
Member

If you try to remove a plugin in read only dir, you get a successful result:

$ bin/plugin --remove marvel
-> Removing marvel 
Removed marvel

But actually the plugin has not been removed.

When installing, if fails properly:

$ bin/plugin -i elasticsearch/marvel/latest
-> Installing elasticsearch/marvel/latest...

Failed to install elasticsearch/marvel/latest, reason: plugin directory /usr/local/elasticsearch/plugins is read only
@dadoonet dadoonet added the bug label Jun 18, 2014
@dadoonet dadoonet self-assigned this Jun 18, 2014
dadoonet added a commit to dadoonet/elasticsearch that referenced this issue Jul 4, 2014
If you try to remove a plugin in read only dir, you get a successful result:

```
$ bin/plugin --remove marvel
-> Removing marvel
Removed marvel
```

But actually the plugin has not been removed.

When installing, if fails properly:

```
$ bin/plugin -i elasticsearch/marvel/latest
-> Installing elasticsearch/marvel/latest...

Failed to install elasticsearch/marvel/latest, reason: plugin directory /usr/local/elasticsearch/plugins is read only
```

This change throw an exception when we don't succeed removing the plugin.

Closes elastic#6546.
dadoonet added a commit that referenced this issue Jul 4, 2014
If you try to remove a plugin in read only dir, you get a successful result:

```
$ bin/plugin --remove marvel
-> Removing marvel
Removed marvel
```

But actually the plugin has not been removed.

When installing, if fails properly:

```
$ bin/plugin -i elasticsearch/marvel/latest
-> Installing elasticsearch/marvel/latest...

Failed to install elasticsearch/marvel/latest, reason: plugin directory /usr/local/elasticsearch/plugins is read only
```

This change throw an exception when we don't succeed removing the plugin.

Closes #6546.

(cherry picked from commit 078cbf3)
dadoonet added a commit that referenced this issue Jul 4, 2014
If you try to remove a plugin in read only dir, you get a successful result:

```
$ bin/plugin --remove marvel
-> Removing marvel
Removed marvel
```

But actually the plugin has not been removed.

When installing, if fails properly:

```
$ bin/plugin -i elasticsearch/marvel/latest
-> Installing elasticsearch/marvel/latest...

Failed to install elasticsearch/marvel/latest, reason: plugin directory /usr/local/elasticsearch/plugins is read only
```

This change throw an exception when we don't succeed removing the plugin.

Closes #6546.

(cherry picked from commit 078cbf3)
@s1monw s1monw removed the v1.2.2 label Jul 8, 2014
@clintongormley clintongormley changed the title Removing plugin does not fail when plugin dir is read only Plugins: Removing plugin does not fail when plugin dir is read only Jul 16, 2014
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
If you try to remove a plugin in read only dir, you get a successful result:

```
$ bin/plugin --remove marvel
-> Removing marvel
Removed marvel
```

But actually the plugin has not been removed.

When installing, if fails properly:

```
$ bin/plugin -i elasticsearch/marvel/latest
-> Installing elasticsearch/marvel/latest...

Failed to install elasticsearch/marvel/latest, reason: plugin directory /usr/local/elasticsearch/plugins is read only
```

This change throw an exception when we don't succeed removing the plugin.

Closes elastic#6546.

(cherry picked from commit 078cbf3)
@lety4ent
Copy link

You could list your plugins with "plugin list".

@SrinivasThodupunuri
Copy link

To uninstall Marvel:
Shut down Elasticsearch and Kibana.
Remove the Marvel agent plugin from Elasticsearch: bin/plugin remove marvel-agent.
Remove the Marvel Kibana app: bin/kibana plugin --remove marvel.
Restart Elasticsearch and Kibana.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants