Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possibility of losing meta configuration on field mapping update #6550

Conversation

spinscale
Copy link
Contributor

The TTL, size, timestamp and index meta properties could be lost on an
update of a single field mapping due to a wrong comparison in the
merge method (which was caused by a wrong initialization, which marked
an update as explicitely disabled instead of unset.

Closes #5053

@s1monw
Copy link
Contributor

s1monw commented Jun 18, 2014

LGTM this should also go into 1.2.2?

@s1monw s1monw removed the review label Jun 18, 2014
…g update

The TTL, size, timestamp and index meta properties could be lost on an
update of a single field mapping due to a wrong comparison in the
merge method (which was caused by a wrong initialization, which marked
an update as explicitely disabled instead of unset.

Closes elastic#5053
@spinscale spinscale merged commit 9569166 into elastic:master Jun 19, 2014
@spinscale spinscale removed the bug label Jun 19, 2014
@spinscale
Copy link
Contributor Author

pushed into master, 1.x and 1.2 (labels are on the issue)

@clintongormley clintongormley added >bug v2.0.0-beta1 v1.3.0 v1.2.2 :Search/Mapping Index mappings, including merging and defining field types labels Jun 7, 2015
@clintongormley clintongormley changed the title Mapping: Fix possibility of losing meta configuration on field mapping update Fix possibility of losing meta configuration on field mapping update Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search/Mapping Index mappings, including merging and defining field types v1.2.2 v1.3.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping: Fix possibility of losing meta configuration on field mapping update
3 participants