Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a transformer to translate constant BigDecimal to double #6609

Merged
merged 1 commit into from Jun 26, 2014
Merged

Add a transformer to translate constant BigDecimal to double #6609

merged 1 commit into from Jun 26, 2014

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Jun 25, 2014

This means the constant 1.42 will be compiled using a double instead of Groovy's default BigDecimal without having to add a f suffix.

@s1monw
Copy link
Contributor

s1monw commented Jun 26, 2014

cool stuff LGTM

@s1monw s1monw removed the review label Jun 26, 2014
@dakrone dakrone merged commit b43b56a into elastic:master Jun 26, 2014
@clintongormley clintongormley changed the title Add a transformer to translate constant BigDecimal to double Scripting: Add a transformer to translate constant BigDecimal to double Jul 16, 2014
@dakrone dakrone deleted the feature/groovy/bigdecimal-transform branch September 9, 2014 13:47
@dakrone dakrone mentioned this pull request May 15, 2015
Closed
@clintongormley clintongormley added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Jun 7, 2015
@clintongormley clintongormley changed the title Scripting: Add a transformer to translate constant BigDecimal to double Add a transformer to translate constant BigDecimal to double Jun 7, 2015
@clintongormley clintongormley mentioned this pull request Aug 11, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement v1.3.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dakrone @s1monw @clintongormley