Set a default of 5m to recover_after_time when any of the expected*Nodes is set
#6742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assertThat(service.recoverAfterTime().millis(), Matchers.equalTo(timeValue.millis())); | ||
| } | ||
|
|
||
| private static class DummyClusterService implements ClusterService { |
There was a problem hiding this comment.
can we move this to our test infra? I think we do this in another place in our code (or one of our branches)
|
LGTM, except for a small comment on the test |
bleskes
added a commit
that referenced
this pull request
Jul 11, 2014
… `expected*Nodes` is set The `recovery_after_time` tells the gateway to wait before starting recovery from disk. The goal here is to allow for more nodes to join the cluster and thus not start potentially unneeded replications. The `expectedNodes` setting (and friends) tells the gateway when it can start recovering even if the `recover_after_time` has not yet elapsed. However, `expectedNodes` is useless if one doesn't set `recovery_after_time`. This commit changes that by setting a sensible default of 5m for `recover_after_time` *if* a `expectedNodes` setting is present. Closes #6742
|
I moved the cluster service noop class to our test infra package and pushed. Thx. |
clintongormley
changed the title
recover_after_time when any to the expected*Nodes is setrecover_after_time when any to the expected*Nodes is set
clintongormley
changed the title
recover_after_time when any to the expected*Nodes is setrecover_after_time when any of the expected*Nodes is set
clintongormley
added
the
:Distributed/Recovery
clintongormley
changed the title
recover_after_time when any of the expected*Nodes is setrecover_after_time when any of the expected*Nodes is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
recovery_after_timetells the gateway to wait before starting recovery from disk. The goal here is to allow for more nodes to join the cluster and thus not start potentially unneeded replications. TheexpectedNodessetting (and friends) tells the gateway when it can start recovering even if therecover_after_timehas not yet elapsed. However,expectedNodesis useless if one doesn't setrecovery_after_time. This commit changes that by setting a sensible default of 5m forrecover_after_timeif aexpectedNodessetting is present.