Improve pending api to include current executing class #6744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the pending tasks api will now include the current executing tasks (with a proper marker boolean flag) this will also help in tests that wait for no pending tasks, to also wait till the current executing task is done closes elastic#6744
| @@ -279,7 +279,7 @@ public void run() { | |||
| timeInQueue = -1; | |||
| } | |||
|
|
|||
| pendingClusterTasks.add(new PendingClusterTask(pending.insertionOrder, pending.priority, new StringText(source), timeInQueue)); | |||
| pendingClusterTasks.add(new PendingClusterTask(pending.insertionOrder, pending.priority, new StringText(source), timeInQueue, pending.executing)); | |||
There was a problem hiding this comment.
can we maybe fix this ctor to just take Pending as the first arg?
There was a problem hiding this comment.
there are a 2 fields (the source and time in queue) that are computed on top of pending, so it would be confusing I think to pass those on top of pending
|
left a small comment other than than LGTM.... oh the PR needs labels ;) |
|
@s1monw put labels, and replied to your comment |
|
LGTM |
kimchy
added a commit
that referenced
this pull request
Jul 5, 2014
the pending tasks api will now include the current executing tasks (with a proper marker boolean flag) this will also help in tests that wait for no pending tasks, to also wait till the current executing task is done closes #6744
clintongormley
changed the title
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the pending tasks api will now include the current executing tasks (with a proper marker boolean flag)
this will also help in tests that wait for no pending tasks, to also wait till the current executing task is done