Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Logger class for BackgroundIndexer #6781

Closed

Conversation

valdisrigdon
Copy link
Contributor

Fixes #6780

@clintongormley
Copy link

Hi @valdisrigdon

Please could I ask you to sign our CLA. http://www.elasticsearch.org/contributor-agreement/

@valdisrigdon
Copy link
Contributor Author

I signed the CLA this morning.

@@ -40,7 +39,7 @@

public class BackgroundIndexer implements AutoCloseable {

private final ESLogger logger = Loggers.getLogger(RecoveryWhileUnderLoadTests.class);
private final ESLogger logger = Loggers.getLogger(BackgroundIndexer.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change this to Loggers.getLogger(getClass());? it is what it should have been to begin with, which is my fault ;)

@bleskes
Copy link
Contributor

bleskes commented Jul 9, 2014

@valdisrigdon I left one little comment. Thx for reporting this!

@valdisrigdon
Copy link
Contributor Author

@bleskes fixed!

@bleskes bleskes closed this in 747fd38 Jul 9, 2014
bleskes pushed a commit that referenced this pull request Jul 9, 2014
@bleskes
Copy link
Contributor

bleskes commented Jul 9, 2014

pushed. thx @valdisrigdon !

@valdisrigdon valdisrigdon deleted the backgroundIndexer_logger branch July 9, 2014 14:56
@jpountz jpountz removed the review label Jul 16, 2014
@clintongormley clintongormley changed the title fixes Logger for BackgroundIndexer Internal: Fixes Logger class for BackgroundIndexer Jul 16, 2014
@clintongormley clintongormley added the :Core/Infra/Logging Log management and logging utilities label Jun 7, 2015
@clintongormley clintongormley changed the title Internal: Fixes Logger class for BackgroundIndexer Fixes Logger class for BackgroundIndexer Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Logging Log management and logging utilities v1.3.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BackgroundIndexer using RecoveryWhileUnderLoadTests for logging
5 participants