Cleanup of the transport request/response messages #6834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * | ||
| */ | ||
| public abstract class TransportMessage<TM extends TransportMessage<TM>> implements Streamable { |
There was a problem hiding this comment.
It seems to me like this class would be simpler if headers were always not null (and just empty in case there is no header).
There was a problem hiding this comment.
Nevermind, I just noticed this is required for bw compatibility.
There was a problem hiding this comment.
However, can you make this class pkg-private?
There was a problem hiding this comment.
I don't think it needs to be package private (some things in the codebase may work on messages regardless of whether it's a request or response)
Now both TransportRequest and TransportResponse inherit from a base TransportMessage that holds the message headers and also now added the remote transport address (where this message came from).
|
LGTM |
|
LGTM too |
|
closed by 25a21c6 |
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now both TransportRequest and TransportResponse inherit from a base TransportMessage that holds the message headers and also now added the remote transport address (where this message came from).