Don't close/reopen IndexWriter when changing RAM buffer size #6856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we close/reopen IW when we change the RAM buffer but that's costly because it means the next NRT reader is a full reopen. The RAM buffer size setting is a live one in IndexWriter, even if there are no buffered docs in RAM when you call it. Separately it would be nice if Lucene let you manage a "reader pool" that could outlive individual IW instances ...
|
LGTM |
mikemccand
added a commit
that referenced
this pull request
Jul 15, 2014
Today we close/reopen IW when we change the RAM buffer but that's costly because it means the next NRT reader is a full reopen. The RAM buffer size setting is a live one in IndexWriter, even if there are no buffered docs in RAM when you call it. Separately it would be nice if Lucene let you manage a "reader pool" that could outlive individual IW instances ... Closes #6856
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we close/reopen IW when we change the RAM buffer but that's
costly because it means the next NRT reader is a full reopen. The RAM
buffer size setting is a live one in IndexWriter, even if there are no
buffered docs in RAM when you call it.
Separately it would be nice if Lucene let you manage a "reader pool"
that could outlive individual IW instances ...