Completion mapping type throws a misleading error on null value #6926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -533,7 +534,7 @@ public void parse(ParseContext context) throws IOException { | |||
| private void serializeNullValue(ParseContext context, String lastFieldName) throws IOException { | |||
| // we can only handle null values if we have mappings for them | |||
| Mapper mapper = mappers.get(lastFieldName); | |||
| if (mapper != null) { | |||
| if (mapper != null && !(mapper instanceof CompletionFieldMapper)) { | |||
There was a problem hiding this comment.
Should we do instance checks here or have something similar to AbstractFieldMapper.isSortable() to decide if a mapper supports a certain feature, is isSupportingNullValue?
There was a problem hiding this comment.
@spinscale Thanks for the suggestion, I think isSupportingNullValue is a cleaner way to do this. Changed as suggested.
|
Updated PR: Now having a null value for a completion field will throw an exception. |
| @@ -286,6 +286,8 @@ public static Loading parse(String loading, Loading defaultValue) { | |||
|
|
|||
| boolean isSortable(); | |||
|
|
|||
| boolean isSupportingNullValue(); | |||
There was a problem hiding this comment.
or shorter: supportsNullValue? (though I might be completely wrong as my English is what it is...)
|
LGTM |
|
@jpountz thanks for the review, I have changed the name to |
clintongormley
changed the title
clintongormley
added
the
:Search/Suggesters
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the mapper service gets a null value for a field, it tries to parse it with the mapper of any previously seen field, if that mapper happens to be CompletionMapper, it throws an error, as it only accepts certain fields.
Closes #6399