Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest filters execution order doesn't reflect javadocs #7019

Closed
javanna opened this issue Jul 24, 2014 · 1 comment · Fixed by #7023
Closed

Rest filters execution order doesn't reflect javadocs #7019

javanna opened this issue Jul 24, 2014 · 1 comment · Fixed by #7023
Assignees
@javanna
Labels
>breaking >bug v1.4.0.Beta1 v2.0.0-beta1

Comments

@javanna
Copy link
Member

javanna commented Jul 24, 2014

RestFilters allow to configure their execution order through the order method. Their javadocs say:

Execution is done from lowest value to highest.

The filters are ordered and executed the opposite way though, from highest to lowest.
@javanna javanna self-assigned this Jul 24, 2014
@javanna javanna mentioned this issue Jul 24, 2014
Merged
javanna added a commit to javanna/elasticsearch that referenced this issue Jul 28, 2014
@javanna
Rest: fixed filters execution order to be from lowest to highest rath…
4e5ad56 
…er than the other way around

Closes elastic#7019
javanna added a commit that referenced this issue Jul 28, 2014
@javanna
Rest: fixed filters execution order to be from lowest to highest rath…
df2e92e 
…er than the other way around

Closes #7019
@javanna
Copy link
Member Author

javanna commented Jul 28, 2014

This issue is marked as breaking as plugins that register multiple REST filters might rely on their wrong ordering, quite a rare usecase though I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javanna javanna

Labels
>breaking >bug v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
1 participant
@javanna