Percolator should cache index field data instances. #7081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -188,11 +188,7 @@ public Filter cacheFilter(Filter filter, @Nullable CacheKeyFilter.Key cacheKey) | |||
| } | |||
|
|
|||
| public <IFD extends IndexFieldData<?>> IFD getForField(FieldMapper<?> mapper) { | |||
| if (disableCaching) { | |||
| return indexQueryParser.fieldDataService.getForFieldDirect(mapper); | |||
There was a problem hiding this comment.
Can we remove this method now?
There was a problem hiding this comment.
I think getForField can stay? Because it is shorter, otherwise all code needs to do context.fielddata() and then invoke getForField()
There was a problem hiding this comment.
Sorry, I wanted to remove getForFieldDirect, not getForField
|
The change looks good to me. Should we add assertions in the percolation tests to ensure that the field data cache is empty at the end of tests? |
|
@jpountz Good idea, but should this be a general check? (Like how we check the circuit breaker after each test) |
|
@martijnvg Probably! |
|
@jpountz I updated the PR to check if the filter cache and field data cache is 0 before stopping the test cluster. |
|
LGTM |
Before the index reader used by the percolator didn't allow to register a CoreCloseListener, but now it does, making it safe to cache index field data cache entries. Creating field data structures is relatively expensive and caching them can save a lot of noise if many queries are evaluated in a percolator call. Closes elastic#6806 Closes elastic#7081
martijnvg
added a commit
that referenced
this pull request
Aug 4, 2014
Before the index reader used by the percolator didn't allow to register a CoreCloseListener, but now it does, making it safe to cache index field data cache entries. Creating field data structures is relatively expensive and caching them can save a lot of noise if many queries are evaluated in a percolator call. Closes #6806 Closes #7081
martijnvg
added a commit
that referenced
this pull request
Aug 4, 2014
Before the index reader used by the percolator didn't allow to register a CoreCloseListener, but now it does, making it safe to cache index field data cache entries. Creating field data structures is relatively expensive and caching them can save a lot of noise if many queries are evaluated in a percolator call. Closes #6806 Closes #7081
martijnvg
added a commit
that referenced
this pull request
Sep 8, 2014
Before the index reader used by the percolator didn't allow to register a CoreCloseListener, but now it does, making it safe to cache index field data cache entries. Creating field data structures is relatively expensive and caching them can save a lot of noise if many queries are evaluated in a percolator call. Closes #6806 Closes #7081
clintongormley
changed the title
clintongormley
added
the
:Search/Percolator
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Before the index reader used by the percolator didn't allow to register a CoreCloseListener, but now it does, making it safe to cache index field data cache entries. Creating field data structures is relatively expensive and caching them can save a lot of noise if many queries are evaluated in a percolator call. Closes elastic#6806 Closes elastic#7081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the index reader used by the percolator didn't allow to register a CoreCloseListener, but now it does, making it safe to cache index field data cache entries.
Creating field data structures is relatively expensive and caching them can save a lot of noise if many queries are evaluated in a percolator call.
Closes #6806