Add a request level flag to control Query Cache #7167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A request level flag, defaults to be unset, to control the query cache. When not set, it defaults to the index level settings, when explicitly set, will override the index level setting closes elastic#7167
| @@ -137,6 +137,8 @@ public MultiSearchRequest add(BytesReference data, boolean contentUnsafe, @Nulla | |||
| searchRequest.types(Strings.splitStringByCommaToArray(parser.text())); | |||
| } else if ("search_type".equals(currentFieldName) || "searchType".equals(currentFieldName)) { | |||
| searchRequest.searchType(parser.text()); | |||
| } else if ("query_cache".equals(currentFieldName) || "queryCache".equals(currentFieldName)) { | |||
There was a problem hiding this comment.
I tend to like migrating such code to ParseFied when adding features. It avoids typos in the camelcase name that wouldn't be caught by tests for example
|
LGTM |
kimchy
added a commit
that referenced
this pull request
Aug 5, 2014
A request level flag, defaults to be unset, to control the query cache. When not set, it defaults to the index level settings, when explicitly set, will override the index level setting closes #7167
kimchy
added a commit
that referenced
this pull request
Sep 8, 2014
A request level flag, defaults to be unset, to control the query cache. When not set, it defaults to the index level settings, when explicitly set, will override the index level setting closes #7167
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A request level flag, defaults to be unset, to control the query cache. When not set, it defaults to the index level settings, when explicitly set, will override the index level setting