Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw IllegalStateException if you try to .addMapping for same type more than once #7243

Closed
wants to merge 1 commit into from
Closed

Throw IllegalStateException if you try to .addMapping for same type more than once #7243

wants to merge 1 commit into from

Conversation

mikemccand
Copy link
Contributor

Closes #7231

@jpountz
Copy link
Contributor

jpountz commented Aug 12, 2014

LGTM

mikemccand added a commit that referenced this pull request Aug 12, 2014
@mikemccand
Java client API: CreateIndexRequestBuilder.addMapping throws IllegalS…
7fa8a0a 
…tateException if you add same type more than once

Previously, it would silently overwrite the previous mapping, which was trappy.

Closes #7231

Closes #7243
mikemccand added a commit that referenced this pull request Sep 8, 2014
@mikemccand @areek
Java client API: CreateIndexRequestBuilder.addMapping throws IllegalS…
dec2997 
…tateException if you add same type more than once

Previously, it would silently overwrite the previous mapping, which was trappy.

Closes #7231

Closes #7243
@clintongormley clintongormley changed the title Throw IllegalStateException if you try to .addMapping for same type more than once Java API: Throw IllegalStateException if you try to .addMapping for same type more than once Sep 10, 2014
@clintongormley clintongormley added the :Core/Infra/Transport API Transport client API label Jun 7, 2015
@clintongormley clintongormley changed the title Java API: Throw IllegalStateException if you try to .addMapping for same type more than once Throw IllegalStateException if you try to .addMapping for same type more than once Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Core/Infra/Transport API Transport client API >enhancement v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java API: CreateIndexRequestBuilder.addMapping should throw exc if that type already has a mapping
3 participants
@mikemccand @jpountz @clintongormley