Bugs with encoding multiple levels of geo precision #7369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +34,12 @@ setup: | |||
| "location": | |||
| "type" : "geo" | |||
| "precision" : "5km" | |||
| "suggest_geo_multi_level": | |||
There was a problem hiding this comment.
can we have a java test for this instead? The REST test are not here to test functionality :)
There was a problem hiding this comment.
I started down that route but the Java API looked to be missing the "context" part of the suggest API - I can roll a change for that into this PR if you want.
There was a problem hiding this comment.
odd isn't ContextSuggestSearchTests using the API?
There was a problem hiding this comment.
I was looking in the wrong place, thanks
1) One issue reported by a user is due to the truncation of the geohash string. Added Junit test for this scenario 2) Another suspect piece of code was the “toAutomaton” method that only merged the first of possibly many precisions into the result. Closes #7368 Added Java test
|
LGTM |
|
Committed in c0aef4a |
clintongormley
changed the title
clintongormley
added
the
:Search/Suggesters
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7368