Allow to get metadata from arbitrary commit points #7376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Today we always use the latest commit point to return the metadata from the store. This might cause problems for snapshot and restore since in contrast to recovery it won't prevent concurrent flushes (lucene commits). This can lead to all kinds of interesting effects if we are snapshotting while flushing. This change uses the IndexCommit to open the metadata snapshot from the store which is consistent with what we snapshot. Closes elastic#7376
s1monw
force-pushed
the
snapshot_from_commit
branch
from
5028790
to
99ef340
Compare
s1monw
added a commit
that referenced
this pull request
Aug 21, 2014
Today we always use the latest commit point to return the metadata from the store. This might cause problems for snapshot and restore since in contrast to recovery it won't prevent concurrent flushes (lucene commits). This can lead to all kinds of interesting effects if we are snapshotting while flushing. This change uses the IndexCommit to open the metadata snapshot from the store which is consistent with what we snapshot. Closes #7376
s1monw
added a commit
that referenced
this pull request
Aug 21, 2014
Today we always use the latest commit point to return the metadata from the store. This might cause problems for snapshot and restore since in contrast to recovery it won't prevent concurrent flushes (lucene commits). This can lead to all kinds of interesting effects if we are snapshotting while flushing. This change uses the IndexCommit to open the metadata snapshot from the store which is consistent with what we snapshot. Closes #7376
Closed
s1monw
added a commit
that referenced
this pull request
Sep 8, 2014
Today we always use the latest commit point to return the metadata from the store. This might cause problems for snapshot and restore since in contrast to recovery it won't prevent concurrent flushes (lucene commits). This can lead to all kinds of interesting effects if we are snapshotting while flushing. This change uses the IndexCommit to open the metadata snapshot from the store which is consistent with what we snapshot. Closes #7376
clintongormley
changed the title
Closed
clintongormley
added
the
:Distributed/Snapshot/Restore
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Today we always use the latest commit point to return the metadata from the store. This might cause problems for snapshot and restore since in contrast to recovery it won't prevent concurrent flushes (lucene commits). This can lead to all kinds of interesting effects if we are snapshotting while flushing. This change uses the IndexCommit to open the metadata snapshot from the store which is consistent with what we snapshot. Closes elastic#7376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we always use the latest commit point to return the metadata from
the store. This might cause problems for snapshot and restore since in
contrast to recovery it won't prevent concurrent flushes (lucene commits).
This can lead to all kinds of interesting effects if we are snapshotting
while flushing. This change uses the IndexCommit to open the metadata snapshot
from the store which is consistent with what we snapshot.