New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use node's cluster name as a default for an incoming cluster state who misses it #7414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter state who misses it ClusterState has a reference to the cluster name since version 1.1.0 (df7474b) . However, if the state was sent from a master of an older version, this name can be set to null. This is an unexpected and can cause bugs. The bad part is that it will never correct it self until a full cluster restart where the cluster state is rebuilt using the code of the latest version. This commit changes the default to the node's cluster name. Relates to elastic#7386
LGTM |
bleskes
changed the title
[Internal] user node's cluster name as a default for an incoming cluster state who misses it
[Internal] use node's cluster name as a default for an incoming cluster state who misses it
Aug 22, 2014
Looks great! Thanks! |
LGTM |
Used this pull request to resolve #7386 locally by:
Then all I had to do was:
So this works. Rather, it worked for me. |
bleskes
added a commit
that referenced
this pull request
Aug 27, 2014
…ter state who misses it ClusterState has a reference to the cluster name since version 1.1.0 (df7474b) . However, if the state was sent from a master of an older version, this name can be set to null. This is an unexpected and can cause bugs. The bad part is that it will never correct it self until a full cluster restart where the cluster state is rebuilt using the code of the latest version. This commit changes the default to the node's cluster name. Relates to #7386 Closes #7414
bleskes
added a commit
that referenced
this pull request
Aug 27, 2014
…ter state who misses it ClusterState has a reference to the cluster name since version 1.1.0 (df7474b) . However, if the state was sent from a master of an older version, this name can be set to null. This is an unexpected and can cause bugs. The bad part is that it will never correct it self until a full cluster restart where the cluster state is rebuilt using the code of the latest version. This commit changes the default to the node's cluster name. Relates to #7386 Closes #7414
clintongormley
changed the title
[Internal] use node's cluster name as a default for an incoming cluster state who misses it
Internal: Use node's cluster name as a default for an incoming cluster state who misses it
Sep 8, 2014
bleskes
added a commit
that referenced
this pull request
Sep 8, 2014
…ter state who misses it ClusterState has a reference to the cluster name since version 1.1.0 (df7474b) . However, if the state was sent from a master of an older version, this name can be set to null. This is an unexpected and can cause bugs. The bad part is that it will never correct it self until a full cluster restart where the cluster state is rebuilt using the code of the latest version. This commit changes the default to the node's cluster name. Relates to #7386 Closes #7414
clintongormley
changed the title
Internal: Use node's cluster name as a default for an incoming cluster state who misses it
Use node's cluster name as a default for an incoming cluster state who misses it
Jun 7, 2015
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…ter state who misses it ClusterState has a reference to the cluster name since version 1.1.0 (df7474b) . However, if the state was sent from a master of an older version, this name can be set to null. This is an unexpected and can cause bugs. The bad part is that it will never correct it self until a full cluster restart where the cluster state is rebuilt using the code of the latest version. This commit changes the default to the node's cluster name. Relates to elastic#7386 Closes elastic#7414
clintongormley
added
:Distributed/Distributed
A catch all label for anything in the Distributed Area. If you aren't sure, use this one.
and removed
:Cluster
labels
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Distributed/Distributed
A catch all label for anything in the Distributed Area. If you aren't sure, use this one.
v1.3.3
v1.4.0.Beta1
v2.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ClusterState has a reference to the cluster name since version 1.1.0 (df7474b) . However, if the state was sent from a master of an older version, this name can be set to null. This is unexpected and can cause bugs. The bad part is that it will never correct itself until a full cluster restart where the cluster state is rebuilt using the code of the latest version.
This commit changes the default to the node's cluster name.
Relates to #7386