Improved Suggest Client API #7507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public static TermSuggestionBuilder termSuggestion(String name) { | ||
| return new TermSuggestionBuilder(name); | ||
| public BytesReference buildAsBytes() { |
There was a problem hiding this comment.
can we have javadocs for these methods? I think it's important for our public APIs that are directly userfacing
|
left minor comments other than that LGTM feel free to push when you fixed them |
- Added SuggestBuilders (analogous to QueryBuilders) - supporting term, phrase, completion and fuzzyCompletion suggestion builders - Added suggest(SuggestionBuilder) to SuggestRequest - previously only suggest(BytesReference) was supported closes elastic#7435
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SuggestBuilders(analogous toQueryBuilders)term,phrase,completionandfuzzyCompletionsuggestion builderssuggest(SuggestionBuilder)toSuggestRequestsuggest(BytesReference)was supportedSuggestBuildersmethods in tests, instead of directly instantiating specific suggestion builder.closes #7435