Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced a transient context to the rest request #7610

Merged
merged 1 commit into from Sep 5, 2014
Merged

Introduced a transient context to the rest request #7610

merged 1 commit into from Sep 5, 2014

Conversation

uboness
Copy link
Contributor

@uboness uboness commented Sep 5, 2014

Similar to the one in TransportMessage. Added the ContextHolder base class where both TransportMessage and RestRequest derive from

Now next to the known headers, the context is always copied over from the rest request to the transport request (when the injected client is used)

Similar to the one in `TransportMessage`. Added the `ContextHolder` base class where both `TransportMessage` and `RestRequest` derive from

Now next to the known headers, the context is always copied over from the rest request to the transport request (when the injected client is used)
@kimchy
Copy link
Member

kimchy commented Sep 5, 2014

LGTM

@uboness uboness merged commit 5df9c04 into elastic:master Sep 5, 2014
@clintongormley clintongormley changed the title Introduced a transient context to the rest request Internal: Introduced a transient context to the rest request Sep 8, 2014
javanna added a commit that referenced this pull request Sep 9, 2014
…ST to transport layer

Also renamed HeadersCopyClientTests since it tests a class that was renamed and removed randomization around client wrapper, as it now needs to be weapped all the time to copy the context, doesn't depend on useful headers that have been registered anymore.

Relates to #7610
javanna added a commit that referenced this pull request Sep 9, 2014
…ST to transport layer

Also renamed HeadersCopyClientTests since it tests a class that was renamed and removed randomization around client wrapper, as it now needs to be weapped all the time to copy the context, doesn't depend on useful headers that have been registered anymore.

Relates to #7610
@jpountz jpountz removed the review label Oct 21, 2014
@clintongormley clintongormley changed the title Internal: Introduced a transient context to the rest request Introduced a transient context to the rest request Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants