Add repository validation #7680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintongormley
changed the title
| if (in.getVersion().onOrAfter(Version.V_1_4_0)) { | ||
| verify = in.readBoolean(); | ||
| } else { | ||
| verify = false; |
There was a problem hiding this comment.
hmm this is different from the default? maybe you can put a comment here why if its' not a bug
|
I did a review, one more thing, can we call this API in the BWC tests too just to make sure we didn't break anything? |
| @@ -20,6 +20,10 @@ | |||
| "timeout": { | |||
| "type" : "time", | |||
| "description" : "Explicit operation timeout" | |||
| }, | |||
| "verify": { | |||
There was a problem hiding this comment.
Wondering if we should also document this new option in create repository doc?
imotov
force-pushed
the
issue-7096-repository-validation
branch
2 times, most recently
from
af6a8b0
to
499074c
Compare
| @@ -92,6 +92,21 @@ Other repository backends are available in these official plugins: | |||
| * https://github.com/elasticsearch/elasticsearch-hadoop/tree/master/repository-hdfs[HDFS Plugin] for Hadoop environments | |||
| * https://github.com/elasticsearch/elasticsearch-cloud-azure#azure-repository[Azure Cloud Plugin] for Azure storage repositories | |||
|
|
|||
|
|
|||
| ===== Repository Verification | |||
| added[1.4.0] | |||
There was a problem hiding this comment.
seems like this goes to 1.5 only ?
|
left only minor comments, LGTM and can go into 1.4? |
|
@imotov can you bring this up to date and push ? |
imotov
force-pushed
the
issue-7096-repository-validation
branch
from
499074c
to
286b603
Compare
|
Merged into 1.4, 1.x and master. |
clintongormley
added
the
:Distributed/Snapshot/Restore
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds automatic and manual verification of repository settings and access rights.
Fixes #7096