[TEST] Expose ability to provide http headers when sending requests in our REST tests #7710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n our REST tests ElasticsearchRestTests has now a `restClientSettings` method that can be overriden to provide headers as settings (similarly to what we do with transport client). Those headers will be sent together with every REST requests within the tests.
javanna
added
>test
|
|
||
| private InetSocketAddress[] addresses; | ||
|
|
||
| private final String esVersion; | ||
|
|
||
| public RestClient(InetSocketAddress[] addresses, RestSpec restSpec) throws IOException, RestException { | ||
| public RestClient(RestSpec restSpec, InetSocketAddress[] addresses, Settings settings) throws IOException, RestException { |
There was a problem hiding this comment.
Is there a specific reason the first two args need to be reversed? I would tend to keep them the same, but I'm not against it changing if there is some kind of justification.
There was a problem hiding this comment.
good point, I'll change the order to this: RestSpec restSpec, Settings settings, InetSocketAddress[] addresses. I think it's more intuitive since the first two args are final while addresses isn't.
I'll also try to come up with another PR to fix these mutability issues in RestClient...
|
Looks fine. Left one minor comment. |
javanna
added a commit
that referenced
this pull request
Sep 15, 2014
…n our REST tests ElasticsearchRestTests has now a `restClientSettings` method that can be overriden to provide headers as settings (similarly to what we do with transport client). Those headers will be sent together with every REST requests within the tests. Closes #7710
javanna
added a commit
that referenced
this pull request
Sep 15, 2014
…n our REST tests ElasticsearchRestTests has now a `restClientSettings` method that can be overriden to provide headers as settings (similarly to what we do with transport client). Those headers will be sent together with every REST requests within the tests. Closes #7710
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…n our REST tests ElasticsearchRestTests has now a `restClientSettings` method that can be overriden to provide headers as settings (similarly to what we do with transport client). Those headers will be sent together with every REST requests within the tests. Closes elastic#7710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElasticsearchRestTestshas now arestClientSettingsmethod that can be overriden to provide headers as settings (similarly to what we do with transport client). Those headers will be sent together with every REST requests within the tests.