Refactor the Translog.read(Location) method #7780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| } | ||
| } catch (IOException e) { | ||
| // switched on us, read it from the reader | ||
| Translog.Operation op = translog.read(versionValue.translogLocation()); |
There was a problem hiding this comment.
this can still cause an IOException no? so we should keep the catch block here?
There was a problem hiding this comment.
oh no it now throws ElasticsearchException which I think is weird it should throw IOException
|
I left some comments |
|
LGTM |
dakrone
force-pushed
the
minor-translog-cleanup
branch
from
6089526
to
168b375
Compare
It was only used by `readSource`, it has been changed to return a Translog.Operation, which can have .getSource() called on it to return the source. `readSource` has been removed. This also removes the checked IOException, any exception thrown is unexpected and should throw a runtime exception. Moves the ReleasableBytesStreamOutput allocation into the body of the try-catch block so the lock can be released in the event of an exception during allocation.
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only used by
readSource, it has been changed to return aTranslog.Operation, which can have .getSource() called on it to return
the source.
readSourcehas been removed.This also removes the checked IOException, any exception thrown is
unexpected and should throw a runtime exception.
Moves the ReleasableBytesStreamOutput allocation into the body of the
try-catch block so the lock can be released in the event of an exception
during allocation.