-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize with flush=true
only works when wait_for_merges=true
#7886
Labels
Comments
Nice catch! It's silly to do that 2nd flush if we didn't wait ... |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this issue
Sep 29, 2014
This does the following: * Make 'force' flag only build a merge if the delegate MP returned no merges * Add async handling for 'flush' when 'waitForMerges' is false * Remove flush at the beginning of optimize. This is something the user can do if they wish, before calling optimize. closes elastic#7886 closes elastic#7904
rjernst
added a commit
that referenced
this issue
Sep 29, 2014
This does the following: * Make 'force' flag only build a merge if the delegate MP returned no merges * Add async handling for 'flush' when 'waitForMerges' is false * Remove flush at the beginning of optimize. This is something the user can do if they wish, before calling optimize. closes #7886 closes #7904 closes #7920
rjernst
added a commit
that referenced
this issue
Sep 30, 2014
This does the following: * Make 'force' flag only build a merge if the delegate MP returned no merges * Add async handling for 'flush' when 'waitForMerges' is false * Remove flush at the beginning of optimize. This is something the user can do if they wish, before calling optimize. closes #7886 closes #7904 closes #7920
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
This does the following: * Make 'force' flag only build a merge if the delegate MP returned no merges * Add async handling for 'flush' when 'waitForMerges' is false * Remove flush at the beginning of optimize. This is something the user can do if they wish, before calling optimize. closes elastic#7886 closes elastic#7904 closes elastic#7920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The implementation of optimize currently has a conditional flush before doing the
forceMerge
, as well as a conditional flush afterwards. However, ifwait_for_merges=false
, the second flush is bogus. It should occur once the force merge is complete.The text was updated successfully, but these errors were encountered: