Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian package contains forbidden-apis signatures files in /usr/share/elasticsearch #7917

Closed
uschindler opened this issue Sep 29, 2014 · 3 comments
Labels
>bug :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v1.3.4 v1.4.0.Beta1 v2.0.0-beta1

Comments

@uschindler
Copy link
Contributor

This is how the /usr/share/elasticsearch directory looks like:

root@host:/usr/share/elasticsearch# ls -l
total 36
-rw-r--r-- 1 root root   77 Sep 29 13:41 all-signatures.txt
drwxr-xr-x 2 root root 4096 Sep 29 18:10 bin
-rw-r--r-- 1 root root 4441 Sep 29 13:41 core-signatures.txt
drwxr-xr-x 3 root root 4096 Sep 29 18:10 lib
-rw-r--r-- 1 root root  150 Sep 29 13:41 NOTICE.txt
-rw-r--r-- 1 root root 8421 Sep 29 13:41 README.textile
-rw-r--r-- 1 root root    0 Sep 29 13:41 test-signatures.txt
root@pangaea-mw1:/usr/share/elasticsearch#

The txt files are relicts caused by packaging *.txt into the debian file. There are two solutions:

  • exclude those files explicit from packaging
  • alternatively rename those files to something like *.sig and change pom.xml

I prefer the second variant. *.txt is stupid for signatures files. This was just copied from Lucene where they are in a separate subdirectory.

@nik9000
Copy link
Member

nik9000 commented Sep 29, 2014

+1

Low priority but probably worth it because it can't be that hard.

rjernst added a commit to rjernst/elasticsearch that referenced this issue Sep 29, 2014
This avoids the files showing up in the binary release, since .txt files
are copied.

closes elastic#7917
rjernst added a commit that referenced this issue Sep 29, 2014
This avoids the files showing up in the binary release, since .txt files
are copied.

closes #7917
closes #7921
@uschindler
Copy link
Contributor Author

Thanks. Moving to dev-tools is also fine, somewhat like in lucene :-)

rjernst added a commit that referenced this issue Sep 30, 2014
This avoids the files showing up in the binary release, since .txt files
are copied.

closes #7917
closes #7921
rjernst added a commit that referenced this issue Sep 30, 2014
This avoids the files showing up in the binary release, since .txt files
are copied.

closes #7917
closes #7921
@s1monw
Copy link
Contributor

s1monw commented Sep 30, 2014

I also ported this to 1.3 and 1.4 branches

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
This avoids the files showing up in the binary release, since .txt files
are copied.

closes elastic#7917
closes elastic#7921
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
This avoids the files showing up in the binary release, since .txt files
are copied.

closes elastic#7917
closes elastic#7921
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v1.3.4 v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants