Support binding on multiple host/port pairs #8098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| profileSettings = settingsBuilder() | ||
| .put(profileSettings) | ||
| .put("port", profileSettings.get("port", componentSettings.get("port", this.settings.get("transport.tcp.port", "9300-9400")))) | ||
| .build(); |
There was a problem hiding this comment.
can we check here if the port is defined on "default" profile level, and if it does, use it? and only if not, revert to the current way to configure ports?
There was a problem hiding this comment.
not sure I follow here, this check happens on the 'default' profile by calling profileSettings.get("port")...
spinscale
force-pushed
the
enhancement/netty-multi-port-binding
branch
from
f8cbfc4
to
331729d
Compare
|
incorporated all your review comments, except the one I didnt understand, maybe have another view.. docs still need to be added |
spinscale
force-pushed
the
enhancement/netty-multi-port-binding
branch
from
331729d
to
0bf901b
Compare
| transport.profiles.dmz.bind_host: 172.16.1.2 | ||
| ``` | ||
|
|
||
| The `default` profile is a special. It is used as fallback for any other profiles, if those do not have a specific configuration setting set. |
There was a problem hiding this comment.
I would also mention that currently, the default profile is how other nodes in the cluster will connect to this node, in the future, we will allow to also have node to node communication that connect over multiple interfaces (profiles)
|
LGTM |
| @@ -48,6 +48,32 @@ between all nodes. Defaults to `false`. | |||
| It also uses the common | |||
| <<modules-network,network settings>>. | |||
|
|
|||
| ==== TCP Transport Profiles | |||
|
|
|||
| Elasticsearch allows to bind to multiple ports on different interfaces by the use of transport profiles. See this example configuration | |||
There was a problem hiding this comment.
allows you to.... use of named transport profiles
This patch allows to create several netty bootstrap, each of which listening on different ports. This will potentially allow for features to listen to different network interfaces for node-to-node or node-to-client communication and is also the base to listen to several interfaces, so that those can be used to speed up cluster communication in the future. Closes elastic#8098
spinscale
force-pushed
the
enhancement/netty-multi-port-binding
branch
from
7a162ed
to
b06b524
Compare
spinscale
added a commit
that referenced
this pull request
Oct 17, 2014
This patch allows to create several netty bootstrap, each of which listening on different ports. This will potentially allow for features to listen to different network interfaces for node-to-node or node-to-client communication and is also the base to listen to several interfaces, so that those can be used to speed up cluster communication in the future. Closes #8098
spinscale
added a commit
that referenced
this pull request
Oct 17, 2014
This patch allows to create several netty bootstrap, each of which listening on different ports. This will potentially allow for features to listen to different network interfaces for node-to-node or node-to-client communication and is also the base to listen to several interfaces, so that those can be used to speed up cluster communication in the future. Closes #8098
clintongormley
changed the title
clintongormley
added
the
:Distributed/Network
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
This patch allows to create several netty bootstrap, each of which listening on different ports. This will potentially allow for features to listen to different network interfaces for node-to-node or node-to-client communication and is also the base to listen to several interfaces, so that those can be used to speed up cluster communication in the future. Closes elastic#8098
|
which version? |
|
@edagarli the issue labels at the top show versions associated with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to bind to more than host and port using the
bind_hostandportproperties. You can basically create differrent profiles, which can also have different tcp and buffer settings.TODO: Documentation, explain possible options