New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup non nested filter to not flip the FixedBitSet returned by the wrapped filter. #8232
Merged
martijnvg
merged 1 commit into
elastic:master
from
martijnvg:bugs/non_nested_filter_stop_flipping
Oct 27, 2014
Merged
Cleanup non nested filter to not flip the FixedBitSet returned by the wrapped filter. #8232
martijnvg
merged 1 commit into
elastic:master
from
martijnvg:bugs/non_nested_filter_stop_flipping
Oct 27, 2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
v1.4.0
v1.5.0
v2.0.0-beta1
>enhancement
review
and removed
v1.4.0
labels
Oct 26, 2014
LGTM I guess this counts as a bugfix and should go on 1.4 and 1.3 as well? |
LGTM |
@s1monw Ok, I'll add it to 1.3 and 1.4 too. |
…et returned by the wrapped filter. If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed. In our case we cache the NonNestedDocsFilter itself so that didn't happen each time this filter was used. However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode() Closes elastic#8227 Closes elastic#8232
martijnvg
force-pushed
the
bugs/non_nested_filter_stop_flipping
branch
from
October 27, 2014 12:58
15595de
to
35ede09
Compare
martijnvg
added a commit
that referenced
this pull request
Oct 27, 2014
…et returned by the wrapped filter. If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed. In our case we cache the NonNestedDocsFilter itself so that didn't happen each time this filter was used. However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode() Closes #8227 Closes #8232
martijnvg
added a commit
that referenced
this pull request
Oct 27, 2014
…et returned by the wrapped filter. If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed. In our case we cache the NonNestedDocsFilter itself so that didn't happen each time this filter was used. However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode() Closes #8227 Closes #8232
martijnvg
added a commit
that referenced
this pull request
Oct 27, 2014
…et returned by the wrapped filter. If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed. In our case we cache the NonNestedDocsFilter itself so that didn't happen each time this filter was used. However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode() Closes #8227 Closes #8232
clintongormley
changed the title
Core: Cleanup non nested filter to not flip the FixedBitSet returned by the wrapped filter.
Internal: Cleanup non nested filter to not flip the FixedBitSet returned by the wrapped filter.
Nov 3, 2014
clintongormley
changed the title
Internal: Cleanup non nested filter to not flip the FixedBitSet returned by the wrapped filter.
Cleanup non nested filter to not flip the FixedBitSet returned by the wrapped filter.
Jun 7, 2015
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…et returned by the wrapped filter. If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed. In our case we cache the NonNestedDocsFilter itself so that didn't happen each time this filter was used. However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode() Closes elastic#8227 Closes elastic#8232
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…et returned by the wrapped filter. If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed. In our case we cache the NonNestedDocsFilter itself so that didn't happen each time this filter was used. However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode() Closes elastic#8227 Closes elastic#8232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed.
In our case we cached the NonNestedDocsFilter itself so flipping bits each time NonNestedDocsFilter was used didn't happen. However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode()
PR for #8227