Remove MLT Field Query #8238
Closed
Remove MLT Field Query #8238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MLT field query is simply replaced by a MLT query set to specififc field. To simplify code maintenance we should deprecate it in 1.4 and remove it in 2.0.
|
Is the plan to also remove it in master? (2.0) |
|
Please also add it to the breaking changes docs for 2.0 in master. |
|
Should we just deprecate it and not remove it? I don't really have an opinion on it. Thoughts? |
|
Given that there is a simple workaround (ie use the |
|
++ to remove |
alexksikes
changed the title
|
LGTM |
clintongormley
changed the title
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MLT field query is simply replaced by a MLT query set to specific field.
To simplify code maintenance we should deprecate it in 1.4 and remove it in
2.0.