Add current translog ID to commit meta before closing #8245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
| currentIndexWriter().close(false); | ||
| { // commit and close the current writer - we write the current tanslog ID just in case | ||
| final long translogId = translog.currentId(); | ||
| indexWriter.setCommitData(MapBuilder.<String, String>newMapBuilder().put(Translog.TRANSLOG_ID_KEY, Long.toString(translogId)).map()); |
There was a problem hiding this comment.
Asking for my own information here, but would it be more efficient to use new HashMap<String, String>(1) because we always know the capacity for the HashMap? The default constructor has an initialCapacity of 16, does it save much to manually lower it?
There was a problem hiding this comment.
almost certainly - I just copy pasted this feel free to cut over the other places ;)
Today we simply close the IW when we have to open a new one if ie. we change merge settings. Yet, the API is deprecated and under the hood it commits the IW. For safety we should add the current translog ID and use rollback instead to not wait for merges.
s1monw
force-pushed
the
remove_deprecated_close
branch
from
e5e1321
to
31db8cc
Compare
|
@dakrone I pushed another commit that fixes the map builder too |
|
LGTM |
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we simply close the IW when we have to open a new one if ie.
we change merge settings. Yet, the API is deprecated and under the hood
it commits the IW. For safety we should add the current translog ID and
use rollback instead to not wait for merges.