Mapping update fails if _all.enabled was set to false - MergeMappingException

[mfussenegger]

In ES 1.4.0 it is no longer possible to update the mapping if _all.enabled has been set to false and _all isn't present in the updating request

create index t:

http put localhost:9200/t/

create mapping:

http put localhost:9200/t/_mapping/default default:='{"dynamic": "strict", "_all": {"enabled": false}}'

update mapping:

http put localhost:9200/t/_mapping/default default:='{"dynamic": "true"}

Fails with:

 "error": "MergeMappingException[Merge failed with failures {[mapper [_all] enabled is false now encountering true]}]", 

If I include _all in the request it works as expected:

http put localhost:9200/t/_mapping/default default:='{"dynamic": "true", "_all": {"enabled": false}}'
{
     "acknowledged": true
}

In 1.3.5 that was possible.

[clintongormley]

@mfussenegger thanks for reporting. i've confirmed this.

Also, updating the _default_ mapping will remove the _all mapping:

DELETE _all 

PUT t

PUT /t/_mapping/_default_ 
{
  "dynamic": "strict",
  "_all": {
    "enabled": false
  }
}

Here, the _all mapping is present:

GET /_mapping

PUT /t/_mapping/_default_ 
{
  "dynamic": "true"
}

And now it is gone:

GET /_mapping

[brwe]

This is a bug indeed, thanks for reporting. opened pr #8426

[ghost]

There seems to be another issue with the _all field in combination with the _default_ mapping:

I recreated the issue here:
https://gist.github.com/miccon/a4869fe04f9010015861#file-strictallmappingtest-java

Failing on 21de386

[brwe]

@pkoenig10 thanks a lot for the test, this is incredibly helpful. It seems to me the issue is not in _all mapper but rather that the type is created when indexing the document even though the indexing fails. I will open a separate issue shortly.

[ghost]

Thanks for the quick reply. Another thing I also noticed is that closing and reopening the index after the failed indexing makes the test pass. So it may be that the type gets somehow created but not persisted.