Set bloom default to false even when Directory doesn't have a codecService #8442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We disabled loading of bloom filters by default a while ago, but in the code we still default to true if the directory is not a StoreDirectory or doesn't have a codecService. I don't know if this ever happens, but in a standalone test (using my own FSDirectory) I suddenly saw bloom filters being loaded so I want to defensively fix this.