New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log4j-extras dependency #8464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
@@ -39,6 +39,15 @@ appender: | |||
type: pattern | |||
conversionPattern: "[%d{ISO8601}][%-5p][%-25c] %m%n" | |||
|
|||
#file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe mention somewhere what the difference between timeBased
rolling policy and a dailyRollingFile
is? Seems quite internal for non log4j users?
LGTM |
dadoonet
added a commit
to dadoonet/elasticsearch
that referenced
this pull request
Nov 19, 2014
PR elastic#8464 come with a bug in the example provided. First, the current log file is not compressed so it should not end with `.gz`. Second, conversion pattern was removing all the log content but was printing only the log date. Then, the current log filename was hardcoded to `elasticsearch` instead of the cluster name.
dadoonet
added a commit
that referenced
this pull request
Nov 19, 2014
PR #8464 come with a bug in the example provided. First, the current log file is not compressed so it should not end with `.gz`. Second, conversion pattern was removing all the log content but was printing only the log date. Then, the current log filename was hardcoded to `elasticsearch` instead of the cluster name. (cherry picked from commit cbced94)
dadoonet
added a commit
that referenced
this pull request
Nov 19, 2014
PR #8464 come with a bug in the example provided. First, the current log file is not compressed so it should not end with `.gz`. Second, conversion pattern was removing all the log content but was printing only the log date. Then, the current log filename was hardcoded to `elasticsearch` instead of the cluster name.
clintongormley
added
the
:Core/Infra/Logging
Log management and logging utilities
label
Mar 19, 2015
clintongormley
changed the title
Logging: Add log4j-extras dependency
Add log4j-extras dependency
Jun 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #7927