Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log4j-extras dependency #8464

Merged
merged 2 commits into from Nov 13, 2014
Merged

Add log4j-extras dependency #8464

merged 2 commits into from Nov 13, 2014

Conversation

colings86
Copy link
Contributor

Close #7927

@javanna
Copy link
Member

javanna commented Nov 13, 2014

LGTM

@javanna javanna removed the review label Nov 13, 2014
@@ -39,6 +39,15 @@ appender:
type: pattern
conversionPattern: "[%d{ISO8601}][%-5p][%-25c] %m%n"

#file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe mention somewhere what the difference between timeBased rolling policy and a dailyRollingFile is? Seems quite internal for non log4j users?

@spinscale
Copy link
Contributor

LGTM

@colings86 colings86 merged commit 34b37ab into elastic:master Nov 13, 2014
@colings86 colings86 deleted the pr/7947 branch November 13, 2014 12:46
dadoonet added a commit to dadoonet/elasticsearch that referenced this pull request Nov 19, 2014
PR elastic#8464 come with a bug in the example provided.

First, the current log file is not compressed so it should not end with `.gz`.
Second, conversion pattern was removing all the log content but was printing only the log date.
Then, the current log filename was hardcoded to `elasticsearch` instead of the cluster name.
dadoonet added a commit that referenced this pull request Nov 19, 2014
PR #8464 come with a bug in the example provided.

First, the current log file is not compressed so it should not end with `.gz`.
Second, conversion pattern was removing all the log content but was printing only the log date.
Then, the current log filename was hardcoded to `elasticsearch` instead of the cluster name.

(cherry picked from commit cbced94)
dadoonet added a commit that referenced this pull request Nov 19, 2014
PR #8464 come with a bug in the example provided.

First, the current log file is not compressed so it should not end with `.gz`.
Second, conversion pattern was removing all the log content but was printing only the log date.
Then, the current log filename was hardcoded to `elasticsearch` instead of the cluster name.
@clintongormley clintongormley added the :Core/Infra/Logging Log management and logging utilities label Mar 19, 2015
@clintongormley clintongormley changed the title Logging: Add log4j-extras dependency Add log4j-extras dependency Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log4j rollingPolicy support
5 participants