Fix geohash grid aggregation on multi-valued fields. #8513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aggregation creates an anonymous fielddata instance that takes geo points and turns them into a geo hash encoded as a long. A bug was introduced in 1.4 because of a fielddata refactoring: the fielddata instance tries to populate an array with values without first making sure that it is large enough. Close elastic#8507
jpountz
added
review
v2.0.0-beta1
v1.5.0
v1.4.1
:Analytics/Aggregations
| @@ -149,6 +149,7 @@ public void setDocument(int docId) { | |||
| geoValues = geoPointValues.geoPointValues(); | |||
| geoValues.setDocument(docId); | |||
| count = geoValues.count(); | |||
| grow(); | |||
There was a problem hiding this comment.
This is a weird API, where you must first set a protected member, then call a protected function. Perhaps it could be reworked to have count be private, and change grow() to resize(int)? I only see 2 cases where count is set, but grow() is not, and they are for 0 and 1, which I think are just special cases and can be skipped on entry to to resize?
|
@rjernst I pushed a new commit. Is it what you had in mind? |
|
Yes, thanks. LGTM. |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aggregation creates an anonymous fielddata instance that takes geo points
and turns them into a geo hash encoded as a long. A bug was introduced in 1.4
because of a fielddata refactoring: the fielddata instance tries to populate
an array with values without first making sure that it is large enough.
Close #8507