Resolve now in date ranges in percolator and alias filters at search time instead of parse time
#8534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Override | ||
| public DocIdSet getDocIdSet(AtomicReaderContext context, Bits acceptDocs) throws IOException { | ||
| return resolve().getDocIdSet(context, acceptDocs); |
There was a problem hiding this comment.
can resolve possibly return null? if so we should check for it
|
left some comments |
|
@s1monw I applied the feedback and left one comment. |
|
LGTM |
…xecuted on the last possible moment to aid with index aliases and percolator queries using `now` date expression. Percolator queries and index alias filters are parsed once and reused as long as they exist on a node. If they contain time based range filters with a `now` expression then the alias filters and percolator queries are going to be incorrect from the moment these are constructed (depending on the date rounding). If a range filter or range query is constructed as part of adding a percolator query or a index alias filter then these get wrapped in special query or filter wrappers that defer the resolution of now at last possible moment as apposed during parse time. In the case of the range filter a special Resolvable Filter makes sure that `now` is resolved when the DocIdSet is pulled and in the case of the range query `now` is resolved at query rewrite time. Both occur at the time the range filter or query is used as apposed when the query or filter is constructed during parse time. Closes elastic#8474 Closes elastic#8534
martijnvg
changed the title
now date ranges in percolator and alias filters at search time instead of parse timenow in date ranges in percolator and alias filters at search time instead of parse time
martijnvg
force-pushed
the
bugs/alias_filter_and_percolator_query_with_now_based_range
branch
from
3dc311d
to
bba6560
Compare
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Nov 19, 2014
…xecuted on the last possible moment to aid with index aliases and percolator queries using `now` date expression. Percolator queries and index alias filters are parsed once and reused as long as they exist on a node. If they contain time based range filters with a `now` expression then the alias filters and percolator queries are going to be incorrect from the moment these are constructed (depending on the date rounding). If a range filter or range query is constructed as part of adding a percolator query or a index alias filter then these get wrapped in special query or filter wrappers that defer the resolution of now at last possible moment as apposed during parse time. In the case of the range filter a special Resolvable Filter makes sure that `now` is resolved when the DocIdSet is pulled and in the case of the range query `now` is resolved at query rewrite time. Both occur at the time the range filter or query is used as apposed when the query or filter is constructed during parse time. Closes elastic#8474 Closes elastic#8534
martijnvg
added a commit
that referenced
this pull request
Nov 19, 2014
…xecuted on the last possible moment to aid with index aliases and percolator queries using `now` date expression. Percolator queries and index alias filters are parsed once and reused as long as they exist on a node. If they contain time based range filters with a `now` expression then the alias filters and percolator queries are going to be incorrect from the moment these are constructed (depending on the date rounding). If a range filter or range query is constructed as part of adding a percolator query or a index alias filter then these get wrapped in special query or filter wrappers that defer the resolution of now at last possible moment as apposed during parse time. In the case of the range filter a special Resolvable Filter makes sure that `now` is resolved when the DocIdSet is pulled and in the case of the range query `now` is resolved at query rewrite time. Both occur at the time the range filter or query is used as apposed when the query or filter is constructed during parse time. Closes #8474 Closes #8534
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Nov 19, 2014
…xecuted on the last possible moment to aid with index aliases and percolator queries using `now` date expression. Percolator queries and index alias filters are parsed once and reused as long as they exist on a node. If they contain time based range filters with a `now` expression then the alias filters and percolator queries are going to be incorrect from the moment these are constructed (depending on the date rounding). If a range filter or range query is constructed as part of adding a percolator query or a index alias filter then these get wrapped in special query or filter wrappers that defer the resolution of now at last possible moment as apposed during parse time. In the case of the range filter a special Resolvable Filter makes sure that `now` is resolved when the DocIdSet is pulled and in the case of the range query `now` is resolved at query rewrite time. Both occur at the time the range filter or query is used as apposed when the query or filter is constructed during parse time. Closes elastic#8474 Closes elastic#8534
clintongormley
changed the title
now in date ranges in percolator and alias filters at search time instead of parse timenow in date ranges in percolator and alias filters at search time instead of parse time
martijnvg
deleted the
bugs/alias_filter_and_percolator_query_with_now_based_range
branch
clintongormley
changed the title
now in date ranges in percolator and alias filters at search time instead of parse timenow in date ranges in percolator and alias filters at search time instead of parse time
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…xecuted on the last possible moment to aid with index aliases and percolator queries using `now` date expression. Percolator queries and index alias filters are parsed once and reused as long as they exist on a node. If they contain time based range filters with a `now` expression then the alias filters and percolator queries are going to be incorrect from the moment these are constructed (depending on the date rounding). If a range filter or range query is constructed as part of adding a percolator query or a index alias filter then these get wrapped in special query or filter wrappers that defer the resolution of now at last possible moment as apposed during parse time. In the case of the range filter a special Resolvable Filter makes sure that `now` is resolved when the DocIdSet is pulled and in the case of the range query `now` is resolved at query rewrite time. Both occur at the time the range filter or query is used as apposed when the query or filter is constructed during parse time. Closes elastic#8474 Closes elastic#8534
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…xecuted on the last possible moment to aid with index aliases and percolator queries using `now` date expression. Percolator queries and index alias filters are parsed once and reused as long as they exist on a node. If they contain time based range filters with a `now` expression then the alias filters and percolator queries are going to be incorrect from the moment these are constructed (depending on the date rounding). If a range filter or range query is constructed as part of adding a percolator query or a index alias filter then these get wrapped in special query or filter wrappers that defer the resolution of now at last possible moment as apposed during parse time. In the case of the range filter a special Resolvable Filter makes sure that `now` is resolved when the DocIdSet is pulled and in the case of the range query `now` is resolved at query rewrite time. Both occur at the time the range filter or query is used as apposed when the query or filter is constructed during parse time. Closes elastic#8474 Closes elastic#8534
clintongormley
added
:Search/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #8474. Percolator queries and index alias filters are parsed once and reused as long as they exist on a node. If they contain time based range filters with a
nowexpression then the alias filters and percolator queries are going to be incorrect from the moment these are constructed (depending on the date rounding).If a
rangefilter orrangequery is constructed as part of adding a percolator query or a index alias filter then these get wrapped in special query or filter wrappers that defer the resolution of now at last possible moment instead of during parse time. In the case of the range filter a special Resolvable Filter makes sure thatnowis resolved when the DocIdSet is pulled and in the case of the range querynowis resolved at query rewrite time. Both occur at the time the range filter or query is used as apposed when the query or filter is constructed during parse time.Note this PR is against the 1.x branch.