Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bloom filter and friends entirely #8571

Closed
s1monw opened this issue Nov 20, 2014 · 0 comments
Closed

Remove Bloom filter and friends entirely #8571

s1monw opened this issue Nov 20, 2014 · 0 comments

Comments

@s1monw
Copy link
Contributor

s1monw commented Nov 20, 2014

We have several issues related to the bloom filter mainly related to memory consumption etc. We disabled it by default on the loading end in 1.4.0 which hasn't show any performance downsides yet. IMO we should remove the support of writing the bloomfilter entirely. In-fact since it's just delegating to another postings format we can even drop the reading code and remove this feature entirely. We should do this for 2.0 and 1.x

@rmuir rmuir closed this as completed in 9ef69f9 Nov 21, 2014
rmuir added a commit that referenced this issue Nov 21, 2014
make the "es090" postings format read-only, just to support old segments. There is a test version that subclasses it with write-capability for testing.

Closes #8571

Conflicts:
	docs/reference/indices/update-settings.asciidoc
	src/main/java/org/elasticsearch/index/codec/postingsformat/BloomFilterPostingsFormat.java
	src/main/java/org/elasticsearch/index/codec/postingsformat/Elasticsearch090PostingsFormat.java
	src/main/java/org/elasticsearch/index/codec/postingsformat/PostingFormats.java
	src/test/java/org/elasticsearch/index/codec/postingformat/DefaultPostingsFormatTests.java
	src/test/java/org/elasticsearch/index/codec/postingformat/ElasticsearchPostingsFormatTest.java
	src/test/java/org/elasticsearch/search/suggest/completion/CompletionPostingsFormatTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant